Replace all pickle load with safe load #2252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yiliu30 <yi4.liu@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security by replacing unsafe pickle.load() calls with a safe loading mechanism to prevent potential code execution vulnerabilities. The changes introduce a centralized safe pickle loading approach and extend the allowed classes for unpickling.
- Extracts and enhances the
SafeUnpicklerclass to module level for reusability - Creates a centralized
_safe_pickle_load()function to replace all directpickle.load()calls - Expands allowed classes to include additional ML frameworks beyond just numpy
Comments suppressed due to low confidence (1)
neural_compressor/utils/utility.py:136
- The variable name "allowed_classes" is misleading as it contains module prefixes, not class names. Consider renaming to "allowed_module_prefixes" or "allowed_modules" for clarity.
allowed_classes = ["nummpy", "torch", "tensorflow", "onnx", "onnxruntime"]
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
chensuyue
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
feature or bug fix or documentation or validation or others
API changed or not
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed