This repository was archived by the owner on Nov 27, 2025. It is now read-only.
Avoid copies in getChecked (cherry-pick from upstream) #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following-up on #68067 ; adding std::move to getChecked method as well.
andrey-golubev
approved these changes
Jul 31, 2025
andrey-golubev
changed the title
Contributor
Author
|
Updated expected copy count from "2" to "1" for CopyCountGet and CopyCountGetChecked tests, as in upstream llvm there are 2 copies while in current npu-plugin-llvm there is just 1 copy generated. In upstream llvm there are 2 copies as the test calls first if (failed(ConcreteT::verifyInvariants(emitErrorFn, args...)))In current npu-plugin-llvm if (failed(ConcreteT::verify(emitErrorFn, args...))) |
hrotuna
reviewed
Aug 5, 2025
AlexandruLorinti
force-pushed
the
move_instead_of_copy
branch
from
47abb97 to
55b2277
Compare
hrotuna
approved these changes
Aug 5, 2025
AlexandruLorinti
added a commit
to AlexandruLorinti/npu-plugin-llvm
that referenced
this pull request
Nov 7, 2025
Cherry-pick from upstream llvm: llvm/llvm-project#147721; adding std::move to getChecked method.
andrey-golubev
pushed a commit
that referenced
this pull request
Nov 10, 2025
Duplicate of PR merged on npu/release/19.x #151 Cherry-pick from upstream llvm: llvm/llvm-project#147721; adding std::move to getChecked method.
ermilindwalekar
pushed a commit
to ermilindwalekar/npu-plugin-llvm
that referenced
this pull request
Nov 27, 2025
…ntel#170) Duplicate of PR merged on npu/release/19.x intel#151 Cherry-pick from upstream llvm: llvm/llvm-project#147721; adding std::move to getChecked method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JIRA ticket
Related PR in NPU Compiler and/or OpenVINO repository with sub-module update
Other related tickets