libopencl-clang.so is missing from 'install' target

[frantisekz]

LLVM 16 tag regressed from LLVM 15 in a way that libopencl-clang.so isn't part of the install target (the .so file gets built just fine, it's just not part of the cmake --install). Header files are installed just fine.

Built with:

/usr/bin/cmake -S . -B redhat-linux-build -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_BUILD_TYPE=Release -DPREFERRED_LLVM_VERSION=16.0.0
/usr/bin/cmake --build redhat-linux-build -j12 --verbose

log snippet:

+ /usr/bin/cmake --install redhat-linux-build
-- Install configuration: "Release"
-- Installing: /builddir/build/BUILDROOT/intel-opencl-clang-16.0.0-1.fc38.x86_64/usr/include/cclang/opencl_clang.h
-- Installing: /builddir/build/BUILDROOT/intel-opencl-clang-16.0.0-1.fc38.x86_64/usr/include/cclang/opencl-c.h
-- Installing: /builddir/build/BUILDROOT/intel-opencl-clang-16.0.0-1.fc38.x86_64/usr/include/cclang/opencl-c-base.h
-- Installing: /builddir/build/BUILDROOT/intel-opencl-clang-16.0.0-1.fc38.x86_64/usr/include/cclang/module.modulemap
+ /usr/lib/rpm/redhat/brp-llvm-compile-lto-elf -O2 -flto=thin -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS --config /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -flto=thin -fno-openmp-implicit-rpath -Wl,--build-id=sha1
Checking for LLVM bitcode artifacts
+ /usr/bin/find-debuginfo -j12 --strict-build-id -m -i --build-id-seed 16.0.0-1.fc38 --unique-debug-suffix -16.0.0-1.fc38.x86_64 --unique-debug-src-base intel-opencl-clang-16.0.0-1.fc38.x86_64 --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 110000000 -S debugsourcefiles.list /builddir/build/BUILD/opencl-clang-1adc46ef38aeba1585b3587b95b6af692a12e4f4
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/redhat/brp-ldconfig
+ /usr/lib/rpm/brp-compress
+ /usr/lib/rpm/redhat/brp-strip-lto /usr/bin/strip
+ /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/check-rpaths
+ /usr/lib/rpm/redhat/brp-mangle-shebangs
+ /usr/lib/rpm/brp-remove-la-files
+ env /usr/lib/rpm/redhat/brp-python-bytecompile '' 1 0 -j12
+ /usr/lib/rpm/redhat/brp-python-hardlink
Processing files: intel-opencl-clang-16.0.0-1.fc38.x86_64
error: File not found: /builddir/build/BUILDROOT/intel-opencl-clang-16.0.0-1.fc38.x86_64/usr/lib64/libopencl-clang.so.*

[frantisekz]

Note for myself/other distribution packagers: Worked around with:

mkdir %{buildroot}%{_libdir}/
cp redhat-linux-build/libopencl-clang.so %{buildroot}%{_libdir}/libopencl-clang.so.16
ln -s %{buildroot}%{_libdir}/libopencl-clang.so.16 %{buildroot}%{_libdir}/libopencl-clang.so

[anbe42]

this is fallout caused by switching from add_llvm_library() to add_library() (commit 743bd15)

add_llvm_library() contains a install(TARGETS ...) call

[wenju-he]

address this issue in #439

[wenju-he]

#439 is merged into ocl-open-160 branch, @frantisekz @anbe42 could you please help to check if this issue is resolved?

[frantisekz]

Yes, the issue is resolved, thanks!