Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMR, SPR, CLX, SKX, BDX, HSX, BDW-DE, WSM-EP*, NHM-*, JKT, IVT : Release event updates #98

Merged
merged 14 commits into from
Aug 28, 2023
Merged

EMR, SPR, CLX, SKX, BDX, HSX, BDW-DE, WSM-EP*, NHM-*, JKT, IVT : Release event updates #98

merged 14 commits into from
Aug 28, 2023

Conversation

edwarddavidbaker
Copy link
Contributor

@edwarddavidbaker edwarddavidbaker commented Aug 25, 2023 •
edited
Loading

Changes

  • EMR
    • Emerald Rapids (0xCF) was previously pointing to SPR core. In this pull request dedicated EMR files are introduced.
  • SPR
    • Release IDQ_BUBBLES.CORE, IDQ_BUBBLES.CYCLES_0_UOPS_DELIV.CORE, and IDQ_BUBBLES.CYCLES_FE_WAS_OK.
    • Update event codes for UNC_CHA_TOR_OCCUPANCY events.
  • CLX
    • Move UNC_CHA_REQUESTS.WRITES_REMOTE from uncore_experimental to uncore.
  • SKX
    • Move UNC_CHA_REQUESTS.WRITES_REMOTE from uncore_experimental to uncore.

Spelling updates

  • BDX
    • Fix requets.
  • HSX
    • Fix requets.
  • BDW-DE
    • Fix requets.
  • WSM-EP-DP
    • Fix poiint.
  • WSM-EP-SP
    • Fix poiint and alloacated.
  • NHM-EP
    • Fix poiint and alloacated.
  • NHM-EX
    • Fix poiint and alloacated.
  • IVT
    • Fix requets, inavailability, accumultes, and conjuection.
  • JKT
    • Fix requets.

edwarddavidbaker and others added 14 commits August 25, 2023 11:07
@edwarddavidbaker @ColinIanKing
BDW-DE: Release v11 event files
3386924 
This commit releases BDW-DE v11 events and updates mapfile.csv
accordingly.

Co-authored-by: Colin Ian King <colin.i.king@gmail.com>
@edwarddavidbaker @ColinIanKing
BDX: Release v22 event files
5bd64e0 
This commit releases BDX v22 events and updates mapfile.csv
accordingly.

Co-authored-by: Colin Ian King <colin.i.king@gmail.com>
@edwarddavidbaker
CLX: Release v1.20 event files
808e591 
This commit releases CLX v1.20 events and updates mapfile.csv
accordingly.
@edwarddavidbaker @ColinIanKing
HSX: Release v28 event files
da82cf2 
This commit releases HSX v28 events and updates mapfile.csv
accordingly.

Co-authored-by: Colin Ian King <colin.i.king@gmail.com>
@edwarddavidbaker @ColinIanKing
IVT: Release v24 event files
3d4b2f4 
This commit releases IVT v24 events and updates mapfile.csv
accordingly.

Co-authored-by: Colin Ian King <colin.i.king@gmail.com>
@edwarddavidbaker @ColinIanKing
JKT: Release v24 event files
3d4a767 
This commit releases JKT v24 events and updates mapfile.csv
accordingly.

Co-authored-by: Colin Ian King <colin.i.king@gmail.com>
@edwarddavidbaker @ColinIanKing
NHM-EP: Release v4 event files
76f177c 
This commit releases NHM-EP v4 events and updates mapfile.csv
accordingly.

Co-authored-by: Colin Ian King <colin.i.king@gmail.com>
@edwarddavidbaker @ColinIanKing
NHM-EX: Release v4 event files
de61441 
This commit releases NHM-EX v4 events and updates mapfile.csv
accordingly.

Co-authored-by: Colin Ian King <colin.i.king@gmail.com>
@edwarddavidbaker
SKX: Release v1.32 event files
5d3cb69 
This commit releases SKX v1.32 events and updates mapfile.csv
accordingly.
@edwarddavidbaker
SPR: Release v1.16 event files
b9e03b9 
This commit releases SPR v1.16 events and updates mapfile.csv
accordingly.
@edwarddavidbaker
EMR: Release v1.00 event files
7af829d 
This commit releases EMR v1.00 events and updates mapfile.csv
accordingly.
@edwarddavidbaker @ColinIanKing
WSM-EP-DP: Release v5 event files
7c95db8 
This commit releases WSM-EP-DP v5 events and updates mapfile.csv
accordingly.

Co-authored-by: Colin Ian King <colin.i.king@gmail.com>
@edwarddavidbaker @ColinIanKing
WSM-EP-SP: Release v4 event files
6acae9d 
This commit releases WSM-EP-SP v4 events and updates mapfile.csv
accordingly.

Co-authored-by: Colin Ian King <colin.i.king@gmail.com>
@edwarddavidbaker
create_perf_json: Add EMR to freerunning counter checks
9f23a78 
Add EMR to the same check as SPR. Fixes "AssertionError: EMR:
iio_free_running UNC_IIO_CLOCKTICKS_FREERUN 0".
@edwarddavidbaker edwarddavidbaker marked this pull request as ready for review August 25, 2023 18:13
@edwarddavidbaker
Copy link
Contributor Author

edwarddavidbaker commented Aug 25, 2023 •
edited
Loading

@ColinIanKing and @captain5050 Thanks for flagging spelling issues and for your patience. Sorry it took a bit of time to propagate spelling fixes. Colin, I've added you to Co-authored-by: to applicable commits. Thanks again for contributing. With that said, there are a few remaining items. I left inflight since it seems to be commonly used. Let me know if you feel strongly about in-flight.

      1 ./ADL/events/alderlake_goldencove_core.json: specualtive ==> speculative
      2 ./BNL/events/Bonnell_core.json: nacro ==> macro
      1 ./IVB/events/ivybridge_core.json: MULsand ==> muls and
      9 ./IVB/events/ivybridge_core.json: Sequenser ==> Sequencer
      2 ./IVB/events/ivybridge_core.json: inavailability ==> unavailability
      1 ./IVB/events/ivybridge_core.json: noncachaeble ==> noncacheable, non-cacheable
      1 ./IVB/events/ivybridge_core.json: oustandings ==> outstandings, outstanding
      2 ./KNL/events/KnightsLanding_core.json: rehad ==> rehab
      2 ./KNM/events/KnightsLanding_core.json: rehad ==> rehab
      2 ./WSM-EX/events/WestmereEX_core.json: alloacated ==> allocated
      2 ./WSM-EX/events/WestmereEX_core.json: poiint ==> point

@edwarddavidbaker
Copy link
Contributor Author

  • Event files reviewed and approved internally.
  • Thanks for reviewing create_perf_json.py Ian.

@edwarddavidbaker edwarddavidbaker merged commit 3c273e2 into intel:main Aug 28, 2023
2 checks passed
@edwarddavidbaker edwarddavidbaker deleted the sync-platforms branch August 28, 2023 16:25
ZhangJing-hub pushed a commit to ZhangJing-hub/linux that referenced this pull request Sep 8, 2023
@captain5050 @acmel
perf vendor events intel: Add emeraldrapids, update sapphirerapids to…
e90da4a 
… v1.16

Add emeraldrapids events that were added at intel's perfmon site in:

  intel/perfmon#98

  "EMR, SPR, CLX, SKX, BDX, HSX, BDW-DE, WSM-EP*, NHM-*, JKT, IVT : Release event
   updates"

  "Emerald Rapids (0xCF) was previously pointing to SPR core. In this
   pull request dedicated EMR files are introduced."

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Colin Ian King <colin.i.king@gmail.com>
Cc: Edward Baker <edward.baker@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Link: https://lore.kernel.org/r/20230829001730.1352769-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
ZhangJing-hub pushed a commit to ZhangJing-hub/linux that referenced this pull request Sep 8, 2023
@captain5050 @acmel
perf vendor events intel: Fix spelling mistakes
03dfa45 
Update perf JSON files with spelling fixes by Colin Ian King
<colin.i.king@gmail.com> contributed in:

intel/perfmon#96 "Fix various spelling mistakes and typos as found using codespell torvalds#96"

This is added on top of the spelling mistakes and release number
updates in:

  intel/perfmon#98 "EMR, SPR, CLX, SKX, BDX, HSX, BDW-DE, WSM-EP*, NHM-*, JKT, IVT : Release event updates"

Some additional spelling fixes reported by Edward Baker
<edward.baker@intel.com> are added on top of this.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Colin Ian King <colin.i.king@gmail.com>
Cc: Edward Baker <edward.baker@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Link: https://lore.kernel.org/r/20230829001730.1352769-3-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
fishilico added a commit to fishilico/shared that referenced this pull request Sep 9, 2023
@fishilico
python/processor/sync_perfmon_definitions: add EMR pairs
2e5c78a 
intel/perfmon#98 added dedicated files for
Emerald Rapids processors.
@edwarddavidbaker edwarddavidbaker mentioned this pull request Sep 11, 2023
Open
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Sep 14, 2023
@captain5050 @acmel
perf vendor events intel: Add emeraldrapids, update sapphirerapids to…
8c994ef 
… v1.16

Add emeraldrapids events that were added at intel's perfmon site in:

  intel/perfmon#98

  "EMR, SPR, CLX, SKX, BDX, HSX, BDW-DE, WSM-EP*, NHM-*, JKT, IVT : Release event
   updates"

  "Emerald Rapids (0xCF) was previously pointing to SPR core. In this
   pull request dedicated EMR files are introduced."

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Colin Ian King <colin.i.king@gmail.com>
Cc: Edward Baker <edward.baker@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Link: https://lore.kernel.org/r/20230829001730.1352769-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Sep 14, 2023
@captain5050 @acmel
perf vendor events intel: Fix spelling mistakes
b333067 
Update perf JSON files with spelling fixes by Colin Ian King
<colin.i.king@gmail.com> contributed in:

intel/perfmon#96 "Fix various spelling mistakes and typos as found using codespell torvalds#96"

This is added on top of the spelling mistakes and release number
updates in:

  intel/perfmon#98 "EMR, SPR, CLX, SKX, BDX, HSX, BDW-DE, WSM-EP*, NHM-*, JKT, IVT : Release event updates"

Some additional spelling fixes reported by Edward Baker
<edward.baker@intel.com> are added on top of this.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Colin Ian King <colin.i.king@gmail.com>
Cc: Edward Baker <edward.baker@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Link: https://lore.kernel.org/r/20230829001730.1352769-3-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captain5050 captain5050 captain5050 approved these changes

@kliang2 kliang2 Awaiting requested review from kliang2 kliang2 is a code owner

@kshiprab kshiprab Awaiting requested review from kshiprab kshiprab is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwarddavidbaker @captain5050