Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

add args unit tests for pmem-ns-init, other minor unit testing improvements #246

Merged
merged 3 commits into from
Apr 30, 2019
Merged

add args unit tests for pmem-ns-init, other minor unit testing improvements #246

merged 3 commits into from
Apr 30, 2019

Conversation

okartau
Copy link
Contributor

@okartau okartau commented Apr 23, 2019

Instead of setting sane values if out-of-bounds values found,
return error and fail the program with error msg.

Work in progress, dont merge yet.
Unit testing of argument values can be added here in same PR.

Resolves #223

@okartau okartau force-pushed the refactor-ns-init-args-check branch 2 times, most recently from af2596b to a6dbe41 Compare April 25, 2019 10:26
@okartau okartau changed the title WIP: pmem-ns-init: move args checking to separate function, add args unit tests WIP: add args unit tests for pmem-ns-init, other minor unit testing improvements Apr 25, 2019
@okartau
Copy link
Contributor Author

okartau commented Apr 25, 2019

I cherry-picked 2 commits from #201 to here so that we can continue in one PR and close #201.
Here we now have added unit tests for pmem-ns-init, and change in Makefile to cover cmd/* in unit testing.

@okartau okartau mentioned this pull request Apr 25, 2019
Closed
@okartau okartau added the testing affects testing, not driver code label Apr 25, 2019
@okartau okartau force-pushed the refactor-ns-init-args-check branch 2 times, most recently from efc0bb7 to 819f695 Compare April 29, 2019 14:36
@okartau okartau changed the title WIP: add args unit tests for pmem-ns-init, other minor unit testing improvements add args unit tests for pmem-ns-init, other minor unit testing improvements Apr 29, 2019
@okartau okartau requested a review from pohly April 29, 2019 19:14
pohly
pohly suggested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything except the coverage commit looks good. Please remove that commit. We need to do more work before a coverage report is complete. I've just created #257 for that.

@okartau okartau mentioned this pull request Apr 30, 2019
Open
okartau added 3 commits April 30, 2019 10:27
@okartau
pmem-ns-init/main.go: moved args checking to separate function
173627a 
Instead of setting sane values if out-of-bounds values found,
return error and fail the program with error msg.
@okartau
Added unit tests for cmd/pmem-ns-init/main.go
6763d20
@okartau
registryserver_test.go: delete dead code and reference to OIM
7795399 
The code about Publish is not used, some copied left-over?
@okartau okartau force-pushed the refactor-ns-init-args-check branch from 819f695 to 7795399 Compare April 30, 2019 07:36
@okartau
Copy link
Contributor Author

okartau commented Apr 30, 2019

Removed coverage commit and force-pushed

@pohly pohly merged commit b965de2 into intel:devel Apr 30, 2019
@okartau okartau deleted the refactor-ns-init-args-check branch May 8, 2019 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pohly pohly pohly approved these changes

Assignees
No one assigned
Labels
testing affects testing, not driver code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

re-factor arguments checking in pmem-ns-init
2 participants
@okartau @pohly