This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Go 1.15.2 #753
Merged
Go 1.15.2 #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalluri
reviewed
Sep 28, 2020
pohly
force-pushed
the
go-1.15.2
branch
2 times, most recently
from
5a33d45 to
3abceef
Compare
|
Updated PR:
|
Closed
That's... hogwash! lz4 is needed on the Jenkins workers. We have an I've removed that commit again. |
We can use the error wrapping that was introduced in Go 1.13 instead. The advantage is that we get rid of one dependency.
Certificates with just CN and no SAN are not accepted anymore by default by the Go 1.15 runtime (https://golang.org/doc/go1.15#commonname). Before we update to Go 1.15, we need to restore support via the GODEBUG variable because otherwise upgrading to the upcoming PMEM-CSI release will break existing installations. This can be reverted once we are sure that all installations use certificates with SAN. Related-to: intel#752
This is an additional sanity check. The main usage is during "make test", but doing it also at runtime doesn't hurt.
We want to use a recent Go with full support for the upcoming PMEM-CSI release. Go 1.15 changes the x509 validation, therefore this update relies on the commit which restores the old behavior via GODEBUG.
|
@avalluri : this seems to be ready. |
avalluri
approved these changes
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of PR #751 to avoid code conflicts and updates to Go 1.15.2 without changing how certificates are handled, i.e. the changed default in the Go runtime is reset to what it was before the update.