[Unitrace] Use L0 core extension to query PCI properties #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Level-Zero 1.3.0 specification, we can use zeDevicePciGetPropertiesExt instead of sysman. Unitrace used sysman in legacy mode (zeInit + ZES_ENABLE_SYSMAN), however this was not supported for Xe2 and newer platforms: https://github.com/intel/compute-runtime/blob/releases/25.22/programmers-guide/SYSMAN.md#support-and-limitations hence leading to an abort from ./src/levelzero/ze_metrics.h:66: `void PrintDeviceList(): Assertion `status == ZE_RESULT_SUCCESS' failed.` on Xe2 and newer devices when calling `unitrace --device-list`. As sysman was only used to query PCI information, we could remove its use and switch to the core extension instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unitrace uses sysman in legacy mode (zeInit + ZES_ENABLE_SYSMAN), however this is not supported for Xe2 and newer platforms: https://github.com/intel/compute-runtime/blob/releases/25.22/programmers-guide/SYSMAN.md#support-and-limitations hence leading to an abort on Xe2 and newer devices when calling
unitrace --device-list.Since Level-Zero 1.3.0 specification, you can use
zeDevicePciGetPropertiesExtinstead of sysman.As sysman is only used to query PCI information, you can remove its use and switch to the core extension instead.