Reduction module #180
Open
Reduction module #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
requested changes
Feb 24, 2025
mkorbel1
reviewed
Feb 24, 2025
mkorbel1
reviewed
Mar 10, 2025
| final Logic Function(List<Logic> inputs, {String name}) _operation; | ||
|
|
||
| /// Specified width of input to each reduction node (e.g., binary: radix=2) | ||
| late final int _radix; |
There was a problem hiding this comment.
primitive types like int and bool, or really any non-hardware-signal/module thing (even Functions like operation), especially when they are directly passed from the user, can be just public final variables with this.radix type of syntax in the constructor. That's also better for when you reference those variables in documentation comments [radix] vs [_radix]
| Logic? clk, | ||
| Logic? enable, | ||
| Logic? reset, | ||
| super.name = 'reduction_tree'}) | ||
| : super(definitionName: 'ReductionTree_R${radix}_L${sequence.length}}') { | ||
| if (sequence.isEmpty) { |
There was a problem hiding this comment.
does this now support empty sequences?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Modified tree reduction to create modules instead of inline assignments.
Related Issue(s)
None
Testing
ran existing tree reduction tests
Backwards-compatibility
No. API and naming match.
Documentation
None required.