Floatingpoint #97
Merged
Floatingpoint #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bug fix and fp8 class * fixed point 8 logic * reuse isLegal
mkorbel1
reviewed
Oct 1, 2024
mkorbel1
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This PR adds FloatingPoint and FloatingPointValue datatypes as well as a toy FloatingPointAdder.
Related Issue(s)
None
Testing
FloatingPointValue has been tested with round-trip testing with the Dart double. The FloatingPointAdder has been subjected to randomized testing with a loose comparison to native Double operations as it has no rounding mode.
Backwards-compatibility
No
Documentation
Yes. A simple introductory documentation markdown page is included in this PR.