Deprecations on Logic in favor of value's isValid and isFloating (#216)

intel · Feb 1, 2023 · a5101dd · a5101dd
1 parent e823fa9
commit a5101dd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/src/logic.dart b/lib/src/logic.dart
@@ -335,9 +335,11 @@ class Logic {
   BigInt get valueBigInt => value.toBigInt();
 
   /// Returns `true` iff the value of this signal is valid (no `x` or `z`).
+  @Deprecated('Use value.isValid instead.')
   bool hasValidValue() => value.isValid;
 
   /// Returns `true` iff *all* bits of the current value are floating (`z`).
+  @Deprecated('Use value.isFloating instead.')
   bool isFloating() => value.isFloating;
 
   /// The [Logic] signal that is driving `this`, if any.

diff --git a/lib/src/modules/gates.dart b/lib/src/modules/gates.dart
@@ -725,7 +725,7 @@ class IndexGate extends Module with InlineSystemVerilog, FullyCombinational {
 
   /// Executes the functional behavior of this gate.
   void _execute() {
-    if (_index.hasValidValue() && _index.value.toInt() < _original.width) {
+    if (_index.value.isValid && _index.value.toInt() < _original.width) {
       final indexVal = _index.value.toInt();
       final outputValue = _original.value.getRange(indexVal, indexVal + 1);
       selection.put(outputValue);

diff --git a/lib/src/synthesizers/systemverilog.dart b/lib/src/synthesizers/systemverilog.dart
@@ -398,9 +398,9 @@ class _SynthModuleDefinition {
           }
           assignments.add(_SynthAssignment(synthDriver, synthReceiver));
         }
-      } else if (driver == null && receiver.hasValidValue()) {
+      } else if (driver == null && receiver.value.isValid) {
         assignments.add(_SynthAssignment(receiver.value, synthReceiver));
-      } else if (driver == null && !receiver.isFloating()) {
+      } else if (driver == null && !receiver.value.isFloating) {
         // this is a signal that is *partially* invalid (e.g. 0b1z1x0)
         assignments.add(_SynthAssignment(receiver.value, synthReceiver));
       }