Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency between LogicValues and Logic #91

Closed
mkorbel1 opened this issue Mar 24, 2022 · 0 comments · Fixed by #115
Closed

Consistency between LogicValues and Logic #91

mkorbel1 opened this issue Mar 24, 2022 · 0 comments · Fixed by #115
Assignees
Labels
enhancement New feature or request

Comments

@mkorbel1
Copy link
Contributor

Motivation

It's confusing that there's slice for Logic and getRange for LogicValues. Also, that Logic has width and LogicValues has length. These, and maybe some other areas, should be made more consistent to reduce confusion. In some cases, maybe both should have both options (e.g. slice and getRange might be more useful in different scenarios but to both), and in other cases one should probably be deprecated and eventually removed.

Desired solution

Consistency between LogicValues and Logic where possible.

Alternatives considered

Leave things inconsistent. Original motivation was that LogicValues acts like a List and Logic acts more like SystemVerilog, but that might not be the right approach.

Additional details

Open to other suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant