Refactor to combine LogicValue and LogicValues into LogicValue, plus some related adjustments
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… work with, not yet all passing
This was
linked to
issues
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
There are a variety of usability and consistency issues with the existing implementation for
LogicValueandLogicValues. This collection of changes attempts to make the API easier to work with.Related Issue(s)
#90
#91
#92
Testing
Mostly, the existing tests covered the functionality. A couple minor changes and additions cover additional areas.
Backwards-compatibility
Yes, but mostly just deprecations rather than backwards-compatibility-breaking changes. Most code should work with these changes.
Documentation
README, Architecture, and API docs updated