Improve exceptions for Logic.put
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
force-pushed
the
putexceptions
branch
from
1b30faf
to
a629fc7
Compare
quekyj
pushed a commit
to quekyj/rohd
that referenced
this pull request
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
The exceptions raised by
Logic.putdon't communicate what signal was having an issue, just what the issue was. This PR adds the name of the signal and makes allputexceptions of typePutException.Related Issue(s)
N/A
Testing
Added one new test that
PutExceptionis thrown when there's a width mismatch. There could be more testing added across other exceptions as part of coverage closure.Backwards-compatibility
No
Documentation
No