Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await registered actions in Simulator #252

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

End of simulation and injected actions are awaited in the Simulator already, but when you register an action with Simulator.registerAction the function is not awaited. This PR makes it more consistent by awaiting actions registered that way as well.

The implementation revealed that additional error handling was needed in some scenarios for Sequentials, as well.

Related Issue(s)

N/A

Testing

Added new tests which cover this behavior and adjusted tests which needed it.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

It is somewhat of a different behavior than was previously there, but the inconsistency makes this change closer to a bug fix than a new feature or API change. It may break code that relied on Simulator.registerAction not awaiting in the Simulator.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Updated documentation for registerAction

@mkorbel1 mkorbel1 merged commit e823fa9 into intel:main Jan 30, 2023
@mkorbel1 mkorbel1 deleted the awaitreg branch January 30, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant