More module and signal naming improvements #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
changed the title
mjayasim9
pushed a commit
to mjayasim9/rohd
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This PR fixes some more naming issues discovered during customer testing after #439.
Portmergeable to avoid calls toconnectIOfrom duplicating signal names in generated SV unnecessarily.reserveDefinitionNameModules from being merged if they have different definitionNames.enums are linked but not generated dart-lang/dartdoc#3584).Related Issue(s)
Fix #345
Testing
Added tests to fix bugs and cover new functionality.
Backwards-compatibility
No, though generated SV will change
Documentation
No