Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow constant Z driving to show up in SV without error #441

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented Dec 1, 2023

Description & Motivation

Sometimes one may wish to explicitly drive a Z (floating) on a signal and have that show up in the generated SystemVerilog (e.g. testbench or behavioral code). There was an assertion in the SV generation to prevent an accidental z from showing up on a floating signal (left undriven). However, if someone explicitly connects a signal to Const('z') (for example) in a way that can't be collapsed away (e.g. in a mux), we should just generate with the Z in there rather than fail with an assertion. This does not guarantee that every Z in the ROHD side will show up as a Z in the SV side, it just enables explicit floating.

Related Issue(s)

N/A

Testing

Added a couple tests reproducing issues as reported by a user

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit caf49b8 into intel:main Dec 1, 2023
2 checks passed
@mkorbel1 mkorbel1 deleted the drivezsv branch December 1, 2023 20:21
mjayasim9 pushed a commit to mjayasim9/rohd that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant