Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline fixes and improvements #447

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Pipeline fixes and improvements #447

merged 3 commits into from
Dec 27, 2023

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

The Pipeline abstraction has some bugs and untested behavior, so this PR addresses those:

  • Add a new exception for when a port does not exist, and throw it if get is called on a pipeline for an un-piped signal.
  • Mark some SSA signals as mergeable to make generated SystemVerilog prettier and less verbose.
  • Expose stageCount for Pipeline
  • Improve documentation comments for pipelining.
  • Fix a bug where get on pipe stages which did not modify a signal returns a floating signal.
  • Add a bunch of new tests for pipelining.

Related Issue(s)

N/A

Testing

Existing tests + new tests added

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit 4636e5a into intel:main Dec 27, 2023
2 checks passed
@mkorbel1 mkorbel1 deleted the pipefix branch December 27, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant