Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inference for xgboost fitted with early-stopping #1350

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

avolkov-intel
Copy link
Contributor

Description

Earlier there was a difference in results between xgboost predictions and predictions of our modelbuilder if xgboost was fitted using early-stopping parameter. This pull request is to fix this issue

@Alexsandruss
Copy link
Contributor

/intelci: run

@avolkov-intel
Copy link
Contributor Author

@Alexsandruss can we merge it?

src/gbt_convertors.pyx Outdated Show resolved Hide resolved
@napetrov
Copy link
Contributor

Also a broader question - can we add tests for this case? we might do this as a second iteration after enabling fix due to release timelines

@avolkov-intel
Copy link
Contributor Author

/intelci: run

@avolkov-intel
Copy link
Contributor Author

Also a broader question - can we add tests for this case? we might do this as a second iteration after enabling fix due to release timelines

Yes, I think we should do this in different pull request to merge that one before release

@samir-nasibli
Copy link
Contributor

Also a broader question - can we add tests for this case? we might do this as a second iteration after enabling fix due to release timelines

Yes, I think we should do this in different pull request to merge that one before release

I am expecting that we are testing the fix in the PR, so it is better to add simple test case in this PR as well.

@napetrov
Copy link
Contributor

Manual testing is fine for this PR integration, but should be added anyway

Copy link
Contributor

@razdoburdin razdoburdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@napetrov napetrov merged commit 27d3f39 into intel:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants