-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inference for xgboost fitted with early-stopping #1350
Fix inference for xgboost fitted with early-stopping #1350
Conversation
/intelci: run |
@Alexsandruss can we merge it? |
Also a broader question - can we add tests for this case? we might do this as a second iteration after enabling fix due to release timelines |
/intelci: run |
Yes, I think we should do this in different pull request to merge that one before release |
I am expecting that we are testing the fix in the PR, so it is better to add simple test case in this PR as well. |
Manual testing is fine for this PR integration, but should be added anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Earlier there was a difference in results between xgboost predictions and predictions of our modelbuilder if xgboost was fitted using early-stopping parameter. This pull request is to fix this issue