switch ProcessGroup related API to use intrusive_ptr #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the changes. |
|
The PR #14 has updated the shared_ptr to intrusive_ptr. Close this PR. |
chengjunlu
pushed a commit
that referenced
this pull request
Feb 14, 2022
* add 22.5 release * add 21.5 oneCCL * fix patch issue * gpu rel 0.3.0 * revert cmake patch * fix path issue * update patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi torch-ccl maintainers, I am currently trying to land pytorch/pytorch#47343, which consists of a series of ProcessGroup C++ API changes, created this PR to ensure we don't break third_party extension APIs in ccl repo. Let me know if you have any questions/concerns. Thanks!