Skip to content

Add aten::_nested_tensor_softmax_with_shape #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 26, 2025
Merged

Add aten::_nested_tensor_softmax_with_shape #1323

merged 6 commits into from
Jan 26, 2025

Conversation

min-jean-cho
Copy link
Contributor

@min-jean-cho min-jean-cho commented Jan 23, 2025 •
edited
Loading

Part of #1141.

Depends on pytorch/pytorch#145467.

  • _nested_tensor_softmax_with_shape

@min-jean-cho min-jean-cho mentioned this pull request Jan 21, 2025
Closed
9 tasks
@min-jean-cho min-jean-cho requested a review from xytintel January 23, 2025 08:02
@xytintel
Copy link
Contributor

@min-jean-cho Why do we need pytorch/pytorch#145467

@min-jean-cho
Copy link
Contributor Author

/usr/bin/ld: /home/sdp/actions-runner/_work/torch-xpu-ops/pytorch/build/lib/libtorch_xpu.so: undefined reference to `at::native::NestedTensor_to_mask(at::Tensor const&, std::optional, std::optional)'

@xytintel, pytorch/pytorch#145467 adds the TORCH_API macro to export the symbol NestedTensor_to_mask, which is needed by libtroch_xpu for NestedTensor_softmax_dropout_xpu.

@xytintel xytintel added this pull request to the merge queue Jan 26, 2025
Merged via the queue into main with commit b6786e3 Jan 26, 2025
8 checks passed
@xytintel xytintel deleted the minjean/_nested_tensor_softmax_with_shape branch January 26, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xytintel xytintel xytintel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@min-jean-cho @xytintel