Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup MKL computation backend for Pytorch XPU operators (Linear Algebra) and enable aten::fft_c2c #526

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CuiYifeng
Copy link
Contributor

@CuiYifeng CuiYifeng commented Jul 2, 2024

The first PR of oneMKL for Pytorch XPU.
Enable first oneMKL Op fft_c2c.
Add environment variable USE_ONEMKL to control whether to build with oneMKL XPU or not.
TODO: #737 align claimed fft data type with CUDA in backward test.

@CuiYifeng CuiYifeng force-pushed the yifeng/fft_c2c branch 2 times, most recently from ee57739 to 797a737 Compare July 4, 2024 16:13
@CuiYifeng CuiYifeng force-pushed the yifeng/fft_c2c branch 3 times, most recently from 72a5828 to d1a5593 Compare July 9, 2024 03:12
@fengyuan14 fengyuan14 marked this pull request as draft July 26, 2024 07:41
@CuiYifeng CuiYifeng force-pushed the yifeng/fft_c2c branch 5 times, most recently from 2e37c81 to fc60425 Compare August 2, 2024 12:41
@CuiYifeng CuiYifeng marked this pull request as ready for review August 2, 2024 12:42
@CuiYifeng CuiYifeng requested a review from fengyuan14 August 5, 2024 01:46
@fengyuan14 fengyuan14 changed the title Init MKL for Pytorch XPU and enable fft_c2c Setup MKL computation backend for Pytorch XPU operators (Linear Algebra) and enable aten::fft_c2c Aug 6, 2024
src/CMakeLists.txt Outdated Show resolved Hide resolved
@xytintel xytintel marked this pull request as draft October 25, 2024 04:32
@CuiYifeng CuiYifeng marked this pull request as ready for review December 17, 2024 03:22
@CuiYifeng CuiYifeng force-pushed the yifeng/fft_c2c branch 2 times, most recently from 87c07e0 to bb01a78 Compare December 24, 2024 03:07
@CuiYifeng CuiYifeng added this to the PT2.7 milestone Dec 24, 2024
@CuiYifeng CuiYifeng force-pushed the yifeng/fft_c2c branch 4 times, most recently from b8e82ed to 1328f9a Compare January 7, 2025 13:20
Copy link
Contributor

@chuanqi129 chuanqi129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add mkl source in https://github.com/intel/torch-xpu-ops/blob/main/.github/scripts/env.sh, and enable the mkl into the build and test

@CuiYifeng CuiYifeng force-pushed the yifeng/fft_c2c branch 2 times, most recently from 5671162 to 69f642b Compare January 10, 2025 02:36
@CuiYifeng CuiYifeng requested a review from xytintel January 10, 2025 02:51
@CuiYifeng
Copy link
Contributor Author

Please add mkl source in https://github.com/intel/torch-xpu-ops/blob/main/.github/scripts/env.sh, and enable the mkl into the build and test

MKL source has been added to CI.

@CuiYifeng
Copy link
Contributor Author

New environment variable USE_ONEMKL is used to control whether to build with ONEMKL XPU or not.

@CuiYifeng CuiYifeng force-pushed the yifeng/fft_c2c branch 3 times, most recently from 86bbdfb to 8f44412 Compare January 13, 2025 07:49
@CuiYifeng CuiYifeng requested a review from fengyuan14 January 14, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants