Add defensive EMMS instructions to each SIMD sort function #183
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-devulap
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some compiler bug, some GCC versions, specifically GCC 9, generate MMX instructions without the required EMMS instruction. This can cause strange and obscure crashes.
A previous version of this problem caused #154, and it now seems to be causing issues with Pytorch. Out of an abundance of caution, this adds defensive EMMS intrinsics to the end of each of the SIMD sorting functions whenever MMX is enabled, to try and make sure this issue never shows up ever again.