[REG] Event callback failed with commit 5844f9f

[xiaolongx]

After flashing the samples with commit 5844f9f, three kinds of samples failed, and they were caused by commit 7d861b2:

1. GPIO: onchange does not work
   Button.js, ButtonEnable.js, AutoButton.js, ButtonLEDs.js, ButtonLEDsAsync.js, TwoButtons.js, Spaceship2.js
2. UART: no serial log output via /dev/ttyACM0
   UART.js
3. BLE: Fail to find Arduino 101 via BLE
   BLE.js, WebBluetoothDemo.js, WebBluetoothGroveLcdDemo.js

Branch	Build ID	Date	Result
master	5844f9f	Nov 28, 2016	FAIL
master	6037375	Nov 28, 2016	PASS

[jprestwo]

#483 should fix this.

Update: Verified it fixed GPIO, but it got merged before I realized that UART.js still has a problem, which I am looking into.

[xiaolongx]

QA retest this issue after #483 is merged, two issues still occurs.

1. GPIO: openAsync does not work
   ButtonLEDsAsync.js, test-gpio.js

Serial Logs:

Async GPIO test with two LEDs and a button...
zjs_gpio_open: invalid pin

2. UART: no serial log output via /dev/ttyACM0
   UART.js

[jprestwo]

#494 fixes both GPIO and UART. The problem was with promises, which had broken after the callback optimization change.

[grgustaf]

@xiaolongx, please retest.

[xiaolongx]

This issue cannot reproduce with commit a162db1 on both Arduino_101 and FRDM_K64F, close