This repository was archived by the owner on Aug 5, 2022. It is now read-only.
docs: Fix readme to reflect zephyr docs for cmake #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZJS cmake instructions were wrong (and did not seem to work) for ZJS. Updated the the same steps that zephyr uses. These steps are also much easier and do not require actually building cmake.
Contributor
|
Hmmm the old instructions worked for me. |
Contributor
|
Yeah, me too but this is what Zephyr says to do now and is a lot faster. +1 |
grgustaf
pushed a commit
that referenced
this pull request
Dec 15, 2017
The ZJS cmake instructions were wrong (and did not seem to work) for ZJS. Updated the the same steps that zephyr uses. These steps are also much easier and do not require actually building cmake. Signed-off-by: James Prestwood <james.prestwood@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZJS cmake instructions were wrong (and did not seem to work)
for ZJS. Updated the the same steps that zephyr uses. These
steps are also much easier and do not require actually building
cmake.