This repository was archived by the owner on Aug 5, 2022. It is now read-only.
[Sensor] Added support for trigger mode #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmy-huang
force-pushed
the
sensor-trigger
branch
5 times, most recently
from
7e59fbd to
9dba6bb
Compare
Added trigger support, since currently in Zephyr, triggers can only be signaledfrom interrupt from x86 side, all the x86 side code is wrapped with BUILD_MODULE_SENSOR_TRIGGER #ifdef so that it can be turn off later when Zephyr changes. The trigger are set to sample in 50Hz, any higher frequency will cause the ring buffer to start dropping change events. Signed-off-by: Jimmy Huang <jimmy.huang@intel.com>
jimmy-huang
force-pushed
the
sensor-trigger
branch
from
9dba6bb to
35bda8e
Compare
grgustaf
reviewed
Nov 23, 2016
arc/src/main.c
Outdated
|
|
||
| if (sensor_channel_get(dev, SENSOR_CHAN_GYRO_ANY, val) < 0) { | ||
| ZJS_PRINT("Cannot read gyroscope channels.\n"); | ||
| ZJS_PRINT("failed to read gyroscope channels.\n"); |
Contributor
There was a problem hiding this comment.
remove period for consistency i guess?
arc/src/main.c
Outdated
| sensor_value_snprintf(buf_y, sizeof(buf_y), &val[1]); | ||
| sensor_value_snprintf(buf_z, sizeof(buf_z), &val[2]); | ||
| ZJS_PRINT("Sending gyro : X=%s, Y=%s, Z=%s\n", buf_x, buf_y, buf_z); | ||
| ZJS_PRINT("sending gyro : X=%s, Y=%s, Z=%s\n", buf_x, buf_y, buf_z); |
Contributor
There was a problem hiding this comment.
let's remove the space before the : like good Americans
arc/src/main.c
Outdated
| ZJS_PRINT("failed to initialize BMI160 sensor\n"); | ||
| } else { | ||
| if (!auto_calibration(bmi160)) { | ||
| if (auto_calibration(bmi160) != 0) { |
Contributor
There was a problem hiding this comment.
You don't really need the != 0, but that's just my personal preferred style, not going to enforce it. :)
scripts/analyze.sh
Outdated
| echo "CONFIG_GPIO_QMSI_1_PRI=2" >> prj.conf.tmp | ||
| echo "CONFIG_SPI=y" >> arc/prj.conf.tmp | ||
| echo "CONFIG_SPI_DW_ARC_AUX_REGS=y" >> arc/prj.conf.tmp | ||
| echo "CONFIG_SPI_DW_INTERRUPT_SEPARATED_LINES=y" >> arc/prj.conf.tmp |
Contributor
There was a problem hiding this comment.
This GPIO and SPI here is specific to the Arduino 101 hardware, we'd eventually need to make that dependent on architecture.
Contributor
There was a problem hiding this comment.
Do the same thing I did for UART:
if [ $BOARD = "arduino_101" ]; then
This is precisely the reason I changed the script to pass in BOARD from the Makefile.
Contributor
Author
There was a problem hiding this comment.
ok, sounds good
Signed-off-by: Jimmy Huang <jimmy.huang@intel.com>
jimmy-huang
force-pushed
the
sensor-trigger
branch
from
9a16373 to
f6f50f2
Compare
Contributor
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added trigger support, since currently in Zephyr, triggers can
only be signaledfrom interrupt from x86 side, all the x86 side
code is wrapped with BUILD_MODULE_SENSOR_TRIGGER #ifdef so that
it can be turn off later when Zephyr changes.
The trigger are set to sample in 50Hz, any higher frequency
will cause the ring buffer to start dropping change events.
Signed-off-by: Jimmy Huang jimmy.huang@intel.com