Do not unconditionally succeed RUSTC_WRAPPER when run by build scripts #9235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it should fix #9227 as well |
Undin
approved these changes
Aug 26, 2022
vlad20012
force-pushed
the
Do_not_unconditionally_succeed_RUSTC_WRAPPER_when_run_by_build_scripts
branch
from
cbe129a
to
41c28dc
Compare
Undin
approved these changes
Aug 29, 2022
src/test/kotlin/org/rustSlowTests/lang/resolve/CargoGeneratedItemsResolveTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/rustSlowTests/lang/resolve/CargoGeneratedItemsResolveTest.kt
Outdated
Show resolved
Hide resolved
intellij-rust-native-helper in `RUSTC_WRAPPER` role unconditionally succeeds `cargo check` invocations tripping up build scripts using `cargo check` to probe for successful compilations. To prevent this from happening the `RUSTC_WRAPPER` now checks if it's run from a build script by looking for the `CARGO_CFG_TARGET_ARCH` env var that cargo sets only when running build scripts.
vlad20012
force-pushed
the
Do_not_unconditionally_succeed_RUSTC_WRAPPER_when_run_by_build_scripts
branch
from
41c28dc
to
f540fe2
Compare
|
Build succeeded: |
bors
bot
deleted the
Do_not_unconditionally_succeed_RUSTC_WRAPPER_when_run_by_build_scripts
branch
|
For QA: I failed to reproduce mentioned issues when Sync tool window shows error. I tested the following scenario:
Before these changes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9198, fixes #9227.
Based on rust-lang/rust-analyzer#13010 and discussion in rust-lang/rust-analyzer#12973.
intellij-rust-native-helper in
RUSTC_WRAPPERrole unconditionally succeedscargo checkinvocations tripping up build scripts usingcargo checkto probe for successful compilations. To prevent this from happening theRUSTC_WRAPPERnow checks if it's run from a build script by looking for theCARGO_CFG_TARGET_ARCHenv var that cargo sets only when running build scripts.changelog: Fix broken
anyhowcompilation whenorg.rust.cargo.evaluate.build.scriptsexperimental feature is enabled