fix: add missing HTTP error handling in MassScannersCron and WhatsMyI…#816
Conversation
|
@regulartim , please take a look on this whenever you have time! |
regulartim
left a comment
There was a problem hiding this comment.
Looks good! 👍
Could you please add tests for the new error handling paths?
0c6164a to
07b942b
Compare
|
@regulartim ,I have added tests for all the new error handling — HTTP errors, network failures, timeouts, invalid JSON, and missing keys. Also made sure execute() marks the task as failed in each case. Let me know if you'd like any changes! |
|
Cool, will review tomorrow. Your git history however is not as it should be, it contains every commit from |
|
sorry for that i will fix it asap. |
…PCron Signed-off-by: remo-lab <remopanda7@gmail.com>
07b942b to
78489f0
Compare
|
Fixed the branch base — rebased onto develop so the history is clean now. Ready for review! |
|
Thanks for your review |
Description
Adds proper HTTP error handling to
MassScannersCronandWhatsMyIPCron.Both cronjobs previously performed HTTP requests without checking response status or handling request failures. This could lead to silent failures (MassScannersCron) or unhandled exceptions (WhatsMyIPCron).
This change aligns them with the existing pattern already used in
FireHolCronandTorExitNodesCron.Related issues
Closes #814
Type of change
Checklist
develop.Ruff) gave 0 errors.