Skip to content

fix: add missing HTTP error handling in MassScannersCron and WhatsMyI…#816

Merged
regulartim merged 1 commit intointelowlproject:developfrom
remo-lab:fix/add-http-error-handling-cronjobs
Feb 18, 2026
Merged

fix: add missing HTTP error handling in MassScannersCron and WhatsMyI…#816
regulartim merged 1 commit intointelowlproject:developfrom
remo-lab:fix/add-http-error-handling-cronjobs

Conversation

@remo-lab
Copy link
Contributor

Description

Adds proper HTTP error handling to MassScannersCron and WhatsMyIPCron.

Both cronjobs previously performed HTTP requests without checking response status or handling request failures. This could lead to silent failures (MassScannersCron) or unhandled exceptions (WhatsMyIPCron).

This change aligns them with the existing pattern already used in FireHolCron and TorExitNodesCron.

Related issues

Closes #814

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklist

  • I have read and understood the rules about how to Contribute to this project.
  • The pull request is for the branch develop.
  • I have added documentation of the new features.
  • Linter (Ruff) gave 0 errors.
  • I have added tests for the feature/bug I solved. All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated.
  • If the GUI has been modified:
    • I have provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

@remo-lab
Copy link
Contributor Author

@regulartim , please take a look on this whenever you have time!

Copy link
Collaborator

@regulartim regulartim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
Could you please add tests for the new error handling paths?

@remo-lab remo-lab force-pushed the fix/add-http-error-handling-cronjobs branch from 0c6164a to 07b942b Compare February 17, 2026 16:33
@remo-lab
Copy link
Contributor Author

@regulartim ,I have added tests for all the new error handling — HTTP errors, network failures, timeouts, invalid JSON, and missing keys. Also made sure execute() marks the task as failed in each case. Let me know if you'd like any changes!

@regulartim
Copy link
Collaborator

Cool, will review tomorrow. Your git history however is not as it should be, it contains every commit from main. Did you create your feature branch based on main instead of develop? If so, please fix this.

@remo-lab
Copy link
Contributor Author

sorry for that i will fix it asap.

…PCron

Signed-off-by: remo-lab <remopanda7@gmail.com>
@remo-lab remo-lab force-pushed the fix/add-http-error-handling-cronjobs branch from 07b942b to 78489f0 Compare February 17, 2026 17:20
@remo-lab
Copy link
Contributor Author

Fixed the branch base — rebased onto develop so the history is clean now. Ready for review!

Copy link
Collaborator

@regulartim regulartim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@regulartim regulartim merged commit 3715184 into intelowlproject:develop Feb 18, 2026
5 checks passed
@remo-lab
Copy link
Contributor Author

Thanks for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants