Skip to content

Remove orphaned containers in gbctl update. Closes #832#833

Merged
regulartim merged 1 commit intodevelopfrom
remove_orphaned_containers
Feb 18, 2026
Merged

Remove orphaned containers in gbctl update. Closes #832#833
regulartim merged 1 commit intodevelopfrom
remove_orphaned_containers

Conversation

@regulartim
Copy link
Collaborator

Description

Run docker compose down --remove-orphans before starting services in cmd_update. Without this, containers from removed services (e.g. RabbitMQ after the django-q2 migration) keep running after an update.

Related issues

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project.
  • The pull request is for the branch develop.
  • I have added documentation of the new features.
  • Linter (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved. All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@regulartim regulartim force-pushed the remove_orphaned_containers branch from e65e4b7 to 64fc3ae Compare February 18, 2026 17:33
@regulartim regulartim marked this pull request as ready for review February 18, 2026 17:34
@regulartim regulartim merged commit 9107676 into develop Feb 18, 2026
4 checks passed
@regulartim regulartim deleted the remove_orphaned_containers branch February 18, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant