Skip to content

Use npm ci in the Dockerfile. Closes #840#841

Merged
regulartim merged 1 commit intodevelopfrom
npm_ci
Feb 19, 2026
Merged

Use npm ci in the Dockerfile. Closes #840#841
regulartim merged 1 commit intodevelopfrom
npm_ci

Conversation

@regulartim
Copy link
Collaborator

@regulartim regulartim commented Feb 19, 2026

Description

This changes the way we install frontend dependencies in order to create reproducible builds. We already use npm ci in .github/workflows/_node.yml.

Related issues

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project.
  • The pull request is for the branch develop.
  • I have added documentation of the new features.
  • Linter (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved. All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@regulartim regulartim requested a review from mlodic February 19, 2026 08:22
@regulartim regulartim marked this pull request as ready for review February 19, 2026 08:25
Copy link
Member

@mlodic mlodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, that's the recommended way in Dockerfiles

@regulartim regulartim merged commit 360ad90 into develop Feb 19, 2026
4 checks passed
@regulartim regulartim deleted the npm_ci branch February 19, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants