-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nerd observable analyzer #2377
Conversation
thanks! we'll help you finish this PR! |
Hello, author of NERD here. Neverthless, we installed and tested it and we think there is still some space for improvement (e.g. in handling of 404 return code, which is not always an error, it is also returned if NERD just doesn't have data about the queried IP (not a good design choice, I know), which should still be considered @standa4, if you give write access to your fork to me (@vaclavbartos) and my colleague (@Michalsus), so we can push into this PR, we will help to improve and finish it. |
@vaclavbartos feel free to open a new pull request at anytime. It's not mandatory to continue from this one. |
Hello, I can add @vaclavbartos and his colleague to my fork so they can finish it. I made this code during the Honeynet project workshop (IntelOwl training) and wanted to share the code. Unfortunately I could not find free time to finish this PR. |
@standa4 Thanks for the access. We'll push the updates soon... |
71c44c4
to
7c48f4e
Compare
Co-authored-by: Michalius <xmatejm00@vutbr.cz> Co-authored-by: standa4 <stanislavb@seznam.cz>
Hello, here are some screenshots of results and a raw JSON of one of the scans. |
hey, thanks for the PR! Would you mind following the PR checklist and fixing linters? |
I helped to finish the last steps! finally completed! |
Thanks! |
(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example:
<feature name>. Closes #999
. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)Description
New observable analyzer for https://nerd.cesnet.cz/ service.
Type of change
Please delete options that are not relevant.
Checklist
develop
dumpplugin
command and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zip
and you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERS
playbook by following this guide.url
that contains this information. This is required for Health Checks._monkeypatch()
was used in its class to apply the necessary decorators.MockUpResponse
of the_monkeypatch()
method. This serves us to provide a valid sample for testing.Black
,Flake
,Isort
) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.tests
folder). All the tests (new and old ones) gave 0 errors.DeepSource
,Django Doctors
or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules