Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Drop or fix darwin build for psutil #42

Closed
nanliu opened this issue Oct 12, 2016 · 4 comments · Fixed by #43
Closed

Drop or fix darwin build for psutil #42

nanliu opened this issue Oct 12, 2016 · 4 comments · Fixed by #43
Labels

Comments

@nanliu
Copy link
Contributor

nanliu commented Oct 12, 2016

psutil does not load on MacOS because we only support cpu metrics on linux

$ snapctl plugin load snap-plugin-collector-psutil
Error loading plugin:
GetMetricTypes call error : darwin not supported by plugin

Upstream gopsutil have resolved the issue, but requires cgo. At this point we need a decision whether we want to support this plugin for MacOS (which requires cgo and we can't easily generate universal binaries), or drop support and delete the darwin binary in the github release page.

cc @intelsdi-x/snap-maintainers

@mbbroberg
Copy link

@nanliu psutil is our go-to example of using Snap, which makes me lean toward fixing it. I know our CI with cgo isn't the easiest. Do we have another plugin requiring cgo?

FYI on this concern @jcooklin.

@marcin-krolik
Copy link
Collaborator

@mjbrender we don't have any other plugin which requires cgo

@sandlbn
Copy link
Contributor

sandlbn commented Oct 13, 2016

@marcin-krolik we have libvirt, and we dropped support for darwin.

@marcin-krolik
Copy link
Collaborator

marcin-krolik commented Oct 13, 2016

@sandlbn thanks, was not aware of this one

nanliu added a commit to nanliu/snap-plugin-collector-psutil that referenced this issue Oct 13, 2016
nanliu added a commit to nanliu/snap-plugin-collector-psutil that referenced this issue Oct 13, 2016
nanliu added a commit to nanliu/snap-plugin-collector-psutil that referenced this issue Oct 14, 2016
nanliu added a commit that referenced this issue Oct 14, 2016
GH-42 fix plugin build on MacOS
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants