Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Fix #285: Allow setting of task name in manifest with override from commandline flag #1123

Closed
wants to merge 1 commit into from

Conversation

geauxvirtual
Copy link
Contributor

Fixes #285

Summary of changes:

  • Only uses --name flag for setting name if --name was set on the command line. Add name field to task manifest will set the name for a task.
  • Add a name field to a task manifest will set the name of the task.
  • Updated example mock-file.json and mock-file.yaml to include name field

Testing done:

  • Verified task name can be set from task manifest or overriding from --name flag

Updated mock-file.json

{
    "version": 1,
    "name": "mock-file",
    "schedule": {
        "type": "simple",
        "interval": "1s"
    },
    "max-failures": 10,
    "workflow": {
        "collect": {
            "metrics": {
                "/intel/mock/foo": {},
                "/intel/mock/bar": {},
                "/intel/mock/*/baz": {}
            },
            "config": {
                "/intel/mock": {
                    "name": "root",
                    "password": "secret"
                }
            },
            "process": [
                {
                    "plugin_name": "passthru",
                    "process": null,
                    "publish": [
                        {
                            "plugin_name": "mock-file",
                            "config": {
                                "file": "/tmp/snap_published_mock_file.log"
                            }
                        }
                    ]
                }
            ]
        }
    }
}

screen shot 2016-08-03 at 10 56 35 am

@intelsdi-x/snap-maintainers

@lmroz
Copy link
Contributor

lmroz commented Aug 3, 2016

@jcooklin
Copy link
Collaborator

jcooklin commented Aug 4, 2016

👍 🚢 it

@geauxvirtual
Copy link
Contributor Author

Closing this as #1127 covers this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants