Fix #1499 update explaination to auto-discovery plugin. #1510
Conversation
|
This is related to: https://github.com/intelsdi-x/snap-packaging/pull/34. There are changes to the packaging repo config file, so we take advantage of new settings such as |
| # of the Snap daemon | ||
| auto_discover_path: /opt/snap/plugins | ||
| # auto_discover_path sets the directory(s) to auto load plugins and tasks on | ||
| # the start of the snap daemon. This can be a comma separated list of directories. |
There was a problem hiding this comment.
giving an example of a comma separated list?
There was a problem hiding this comment.
The example below is two directories, one for plugins, one for tasks.
There was a problem hiding this comment.
oh, it does not use command instead of ":"?
|
Since the packaging repo isn't public, I just want to check and make sure the follow changes are sensible defaults for snapteld.conf. I've also created a PR for snap-docker, but left out max_plugin_restarts because that is not compatible with older versions of snap, which will prevent the containers from starting if we ci older versions such as: SNAP_VERSION=0.19.0. cc: @intelsdi-x/snap-maintainers |
|
I would be more conservative with |
|
LGTM |
|
I'll switch max_plugin_restarts back to the default for the package to keep everything consistent. |
No description provided.