Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Adds support for building Snap on Windows and FreeBSD #1528

Merged
merged 5 commits into from
Feb 17, 2017

Conversation

jcooklin
Copy link
Collaborator

@jcooklin jcooklin commented Feb 16, 2017

Fixes: #1527
Related: #1506 #671

Summary of changes:

  • Adds portability of build scripts so building works on
    • FreeBSD
    • Windows

Testing done:

  • Built snap on
    • FreeBSD
    • Windows
      • caveats
        • required: MinGW
        • Makefile is not supported (use scripts directly)
          • scripts/deps.sh
          • scripts/build_all.sh
          • ....
    • Darwin
    • Linux

Windows:
img

FreeBSD:
img

cc: @brd @swills @stdale @jessemillar

This PR incorporates work done by @brd @stdale @IRCody for making snap build on FreeBSD and @jessemillar for Windows. Thanks for your contributions.

@intelsdi-x/snap-maintainers

jcooklin and others added 5 commits February 14, 2017 14:33
- GOOS and GOARCH can be effectively detected by 'go env'
- Supports MinGW
- This makes the path to the plugin have the correct slash on Windows
@jcooklin jcooklin changed the title Fb/portable build Adds support for building snap on Windows and FreeBSD Feb 16, 2017
@jcooklin jcooklin changed the title Adds support for building snap on Windows and FreeBSD Adds support for building Snap on Windows and FreeBSD Feb 16, 2017
@kjlyon
Copy link
Contributor

kjlyon commented Feb 16, 2017

👍

@brd
Copy link

brd commented Feb 16, 2017

Nice! Thanks for helping get this support in.

I don't suppose you guys have contacts at Travis-CI? It would be nice to have you guys lean on them to provide FreeBSD Builders. I know a bunch of people have asked, but they are dragging their feet.

@swills
Copy link

swills commented Feb 16, 2017

I've setup a Jenkins build job for this, you can view it here:

https://jenkins.mouf.net/job/intelsdi-x-snap/

Build Status

For now it's pointing at jcooklin's fb/portable-build branch. I can update it when this is merged.

@nanliu
Copy link
Contributor

nanliu commented Feb 17, 2017

@swills, nice! We can duplicate the job in https://ci.snap-telemetry.io/ and add the webhooks in github so you don't have to host it.

@brd, we have support with travis, but not sure that will move the needle. I can send them an email and see where that takes us.

@swills
Copy link

swills commented Feb 17, 2017

@nanliu Cool. You'll have to setup a FreeBSD based build slave for Jenkins.

@jessemillar
Copy link

👍

@brd
Copy link

brd commented Feb 17, 2017

@nanliu Thanks for helping all the same :)

@jcooklin jcooklin merged commit 7fc6a2f into intelsdi-x:master Feb 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants