This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
[WIP: do-not-merge] Windows Installer #1594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added beginning of scripts for Windows installation.
- Adds 'setlocal' so the user isn't left in a different location after execution the script
Compiles snaptel
- This makes the path to the plugin have the correct slash on Windows
- GOOS and GOARCH can be effectively detected by 'go env' - Supports MinGW
Build binaries and load plugin on Windows
…s the executable in Program Files (for now) and installs a service that starts automatically.
Snap themed installer that installs snap.exe and an application menu shortcut to a selected directory. (We will probably want better images in the long run)
Added service for snapteld but it's returning errors because the path is wrong or when it is correct it doesn't properly run in the background and the installer times out thinking it's failed.
Added service for snapteld but it's returning errors because the path is wrong or when it is correct it doesn't properly run in the background and the installer times out thinking it's failed.
- Adds event for when plugins are unsubscribed - Listens for unsubscription event before asserting
First attempt using WiX Editor. Generated simple installer that places the executable in Program Files (for now) and installs a service that starts automatically. WiX Generated with VS Snap themed installer that installs snap.exe and an application menu shortcut to a selected directory. (We will probably want better images in the long run) MSI Updates Added service for snapteld but it's returning errors because the path is wrong or when it is correct it doesn't properly run in the background and the installer times out thinking it's failed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #671
Summary of changes:
Testing done:
@intelsdi-x/snap-maintainers