Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Hide beta builds after last rust release #32

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

javierpedreira
Copy link
Contributor

Rust Beta builds are failing because of this.
rust-lang/rust#59411
Until they fix it we'll allow Beta fails

@javierpedreira javierpedreira force-pushed the add-bet-to-allowed-failures branch from fd7d4c0 to 7422b50 Compare April 16, 2019 08:14
@kittsville
Copy link
Contributor

The discussion in the linked thread suggests using Xenial should be enough to avoid build failures, so we don't need to allow beta failures.

@nathankleyn
Copy link
Contributor

@kittsville Hah! Crossover! @javierpedreira were literally just talking about this — have added xenial as a test and then will remove the allowed failure on beta if it's green. 🤞

[09:13] Nathan Kleyn
funnily enough this is the first time i’ve ever got a breakage on a build from a beta rust
so as soon as it’s green again, we should probably renable it
because beta gets promoted to stable and our build will just use it

.travis.yml Outdated
@@ -13,6 +13,7 @@ matrix:
fast_finish: true
allow_failures:
- rust: nightly
- rust: beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now we know beta works on Xenia’s, let’s make it required again to prevent problems with automatic upgrades of stable.

@javierpedreira javierpedreira force-pushed the add-bet-to-allowed-failures branch from 7422b50 to 00eac16 Compare April 16, 2019 12:08
Copy link
Contributor

@kittsville kittsville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kittsville kittsville dismissed nathankleyn’s stale review April 16, 2019 14:59

Changes implemented as requested

@kittsville kittsville merged commit bcab3e3 into master Apr 16, 2019
@kittsville kittsville deleted the add-bet-to-allowed-failures branch April 16, 2019 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants