This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Fix osx builds #35
Merged
Fix osx builds #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathankleyn
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
LGTM! 👏
@javierpedreira do you want to try a tagged build and check the release binary uploads correctly before we merge this?
|
@javierpedreira So looks like build failed here on Rust stable on MacOS because |
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
====================================
Coverage 70% 70%
====================================
Files 3 3
Lines 220 220
====================================
Hits 154 154
Misses 66 66 |
javierpedreira
force-pushed
the
fix-osx-builds
branch
5 times, most recently
from
dd5ada1 to
05b77be
Compare
Add missing packages for cmake
On Travis, depending on what OS you are building on, this may or may not be set — and I suppose it's infinitely possible this could be the case on a user's machine too! So, instead, we now set the signature (that is, email, user's name and time) of the commit to a statically defined thing we control in the tests. This fixes the test failures we see on at least MacOS on Travis CI.
javierpedreira
force-pushed
the
fix-osx-builds
branch
from
05b77be to
a16b1bf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enabled osx builds and fixed some related issues to compile and run test coverage for osx.
Closes #27