Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwl oscar #14

Merged

Conversation

SergioLangaritaBenitez
Copy link

No description provided.

@@ -6,7 +6,13 @@ inputs:
scenario: string
# data_catalog: File
wflow_update_script: File

oscarScript: File
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the document uses snake case instead of camel case, please modify it.

password: string
service: string
filename: File
oscarService: Directory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to snake case

@@ -41,19 +47,35 @@ steps:
in:
fa_database: setup_wflow_event/fa_database_out
scenario: scenario
oscarScript: oscarScript
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to snake case

password: password
service: service
filename: filename
oscarService: oscarService
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to snake case

run_wflow_event:
in:
fa_database: run_wflow_warmup/fa_database_out
scenario: scenario
oscarScript: oscarScript
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to snake case

@@ -1,24 +1,17 @@
file:
oscarScript:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to snake case

@@ -14,7 +14,13 @@ inputs:
script_arrange: File
script_update_fiat: File
script_run_fiat: File

oscarScript: File
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to snake case

password: string
service: string
filename: File
oscarService: Directory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to snake case

class: File
path: cwl_OSCAR/wflow_input.tar
oscarService:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to snake case



oscarScript:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to snake case

@@ -0,0 +1,22 @@
functions:
oscar:
- oscarr:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oscarr?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it

@esparig
Copy link

esparig commented Nov 7, 2024

Ok, ship it!

@SergioLangaritaBenitez SergioLangaritaBenitez merged commit a8fba02 into interTwin-eu:oscar_tryout Nov 8, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants