fix: adjust DistinctFlag.__call__ for python 3.12.3+ #1658
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
On Python 3.12.3 onwards (specifically 3.12.3), a change to
EnumType.__call__
messed up our own overriding of the same function atDistinctFlag.__call__
, causing issues like those seen in #1657. This PR fixes that with version-specific code.Changes
DistinctFlag.__call__
use a separate branch of code for 3.12.3+.EnumType.__call__
due to a singleton that is not exported. This adds quite a burden to us, but hopefully it should be alright.Related Issues
Fixes #1657.
Test Scenarios
Python Compatibility
3.10.x
3.12.3
Checklist
pre-commit
code linter over all edited files