support individual key for validation

[ota42y]

Now schema validator doesn't support yet so we use merged parameter.
https://github.com/interagent/committee/blob/master/lib/committee/schema_validator/open_api_3.rb#L59

This problem caused this issue #328
So we should validation by individual key.

Add validate_by_merged_param option

To avoid breaking backward compatibility, we should add this option and do old validation.

save query hash to key

Now we save query hash to merged key

committee/lib/committee/schema_validator/open_api_3.rb

Lines 81 to 84 in 20de9ad

	query_param = unpacker.unpack_query_params(request)
	request.env[validator_option.params_key] = Committee::Utils.indifferent_hash
	request.env[validator_option.params_key].merge!(Committee::Utils.deep_copy(query_param))

The last step in validation, we copy query hash to individual key

committee/lib/committee/schema_validator/open_api_3.rb

Lines 89 to 99 in 20de9ad

	def copy_coerced_data_to_query_hash(request)
	return if request.env["rack.request.query_hash"].nil? || request.env["rack.request.query_hash"].empty?
	query_hash_key = @validator_option.query_hash_key
	return unless query_hash_key
	request.env[query_hash_key] = {} unless request.env[query_hash_key]
	request.env["rack.request.query_hash"].keys.each do |k|
	request.env[query_hash_key][k] = request.env[validator_option.params_key][k]
	end
	end

But this is bad code.
We should copy to individual key in request_unpack method.

        request.env[validator_option.params_key]= unpacker.unpack_query_params(request)

validate query parameter and request parameter

Now we check parameter by method name.
This method expect only one and merged parameter

committee/lib/committee/schema_validator/open_api_3/operation_wrapper.rb

Lines 42 to 58 in 1d9b924

	def validate_request_params(params, headers, validator_option)
	ret, err = case request_operation.http_method
	when 'get'
	validate_get_request_params(params, headers, validator_option)
	when 'post'
	validate_post_request_params(params, headers, validator_option)
	when 'put'
	validate_post_request_params(params, headers, validator_option)
	when 'patch'
	validate_post_request_params(params, headers, validator_option)
	when 'delete'
	validate_get_request_params(params, headers, validator_option)
	else
	raise "Committee OpenAPI3 not support #{request_operation.http_method} method"
	end
	raise err if err
	ret

So we need to fix this method to get individual parameter and merge it like this.

        def validate_request_params(query_param, path_hash, request_body_hash, headers, validator_option)
          request_operation.validate_request_parameter(query_param, headers, build_openapi_parser_get_option(validator_option))
          request_operation.validate_request_body(content_type, params, schema_validator_options)   
        end

[ota42y]

this change resolve #339

[hlascelles]

Terrific 🚀. Let me know if we can help with this.

[ota42y]

That's very nice of you to say !!!
If you are interested, you can try to implement this feature.

[wanglian]

any plan to release this guys?