Include custom data in scope sent to rollbar #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this does not seem to be working correctly. I'll investigate and update when this is ready. |
mikehale
force-pushed
the
rollbar-custom-context
branch
2 times, most recently
from
370e98e to
2bdba4a
Compare
mikehale
force-pushed
the
rollbar-custom-context
branch
from
bb9d2cc to
b5df34f
Compare
mikehale
changed the title
mikehale
force-pushed
the
rollbar-custom-context
branch
from
c9b96f6 to
b5df34f
Compare
|
@gudmundur this is ready for review now. |
gudmundur
requested changes
Mar 16, 2017
.travis.yml
Outdated
| @@ -9,6 +9,8 @@ before_install: | |||
| - gem update --system | |||
| before_script: | |||
| - createdb pliny-gem-test | |||
| before_install: | |||
| - gem update --system | |||
There was a problem hiding this comment.
Would you mind removing this? This has already been addressed with ae7dc84.
| @@ -18,7 +18,7 @@ def notify(exception, context:, rack_env:) | |||
| private | |||
|
|
|||
| def fetch_scope(context:, rack_env:) | |||
| scope = {} | |||
| scope = { custom: context } | |||
There was a problem hiding this comment.
Weakly held opinion, but is there a reason we don't call this context? Does that name hold some significance to Rollbar?
There was a problem hiding this comment.
It does hold significance to rollbar. Outside of the request object, they require data be under a custom key. See https://rollbar.com/docs/api/items_post/.
mikehale
force-pushed
the
rollbar-custom-context
branch
from
b5df34f to
67403ac
Compare
|
@gudmundur comments addressed. |
gudmundur
approved these changes
Mar 17, 2017
|
@mikehale Cheers! 🍻 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the provided context in the rollbar scope. Previously the context was ignored and not included in the scope. This is similar to how scope is defined for rails in rollbar: https://rollbar.com/docs/notifier/rollbar-gem/#the-scope