Allow activesupport 5 or 6 #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a very minimal dependency on active support - limited to the inflection extensions in a generator, and some time extensions in a test. So it seems safe to continue allowing 5, while opening up 6. We'll lock out 7 because it doesn't exist, and we don't know what, if any, breaking changes it will bring.
Rake is way out of date, and we really on use it as a binary, so it's pretty low risk. rack-test is purely a dev resource for pliny, even though it's in the template Gemfile for `pliny new`. But it's got no version restraints there, so again, very low risk.
stevenharman
force-pushed
the
allow_activesupport_6
branch
from
3679ee5 to
d05eca5
Compare
bensymonds
reviewed
Jan 22, 2020
There was a problem hiding this comment.
This seems ok to me! The only thought I had was whether we want to make travis run the tests against both major versions of activesupport, like it already does with sinatra. It seems pretty straightforward to do so maybe worth it, even given how little activesupport is used..?
Excellent idea. I will see get that added. |
stevenharman
force-pushed
the
allow_activesupport_6
branch
from
092d7b4 to
edb859f
Compare
Because ActiveSupport 6 requires at least Ruby 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a very minimal dependency on active support - limited to the inflection extensions in a generator, and some time extensions in a test. So it seems safe to continue allowing 5, while opening up 6. We'll lock out 7 because it doesn't exist, and we don't know what, if any,
breaking changes it will bring.