Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nomination pallet for deposit and withdraw of collateral #519

Closed
bvotteler opened this issue Dec 21, 2022 · 2 comments · Fixed by #506
Closed

Use nomination pallet for deposit and withdraw of collateral #519

bvotteler opened this issue Dec 21, 2022 · 2 comments · Fixed by #506
Assignees
@bvotteler
Labels
prio:high

Comments

@bvotteler
Copy link
Contributor

Use nomination.{depositCollateral | withdrawCollateral} instead of vaultRegistry.{depositCollateral | withdrawCollateral}.

The pallet is already used in DefaultNominationAPI, we want to switch over DefaultVaultAPI's withdraw/deposit methods to use that pallet, too.

In preparation for parachain version 1.21.0 (see also interlay/interbtc#781).
@bvotteler
Copy link
Contributor Author

Blocked by polkadot-js/api#5383 (comment)

@bvotteler bvotteler mentioned this issue Dec 21, 2022
Merged
@bvotteler bvotteler self-assigned this Dec 21, 2022
@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
@nud3l nud3l moved this from Todo ⏳ to Development 🏗️ in Backlog Jan 3, 2023
@bvotteler
Copy link
Contributor Author

Blocked by polkadot-js/api#5383 (comment)

Unblocked with merge of polkadot-js/api#5395

@github-project-automation github-project-automation bot moved this from Development 🏗️ to Done ✅ in Backlog Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvotteler bvotteler

Labels
prio:high
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: Use nomination pallet for deposit/withdraw collateral extrinsics
1 participant
@bvotteler