[BREAKING] Refactor: remove vault collateral interface #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
force-pushed
the
refactor/remove-vault-collateral
branch
from
47750de to
140335e
Compare
sander2
changed the title
9 tasks
gregdhill
approved these changes
Nov 18, 2022
| @@ -31,6 +31,7 @@ fee = { path = "../fee", default-features = false } | |||
| security = { path = "../security", default-features = false } | |||
| currency = { path = "../currency", default-features = false } | |||
| vault-registry = { path = "../vault-registry", default-features = false } | |||
| nomination = { path = "../nomination", default-features = false } | |||
There was a problem hiding this comment.
This can be a dev-dependency right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make vaults use the nomination interface instead of a dedicated vault-collateral interface.
In draft since this will require a migration that I still have to writeafter further consideration, this shouldn't require a migration since we're still using the same storage items.For downstream consumers, the required changes are:
vault_registry.deposit_collateralandvault_registry.withdraw_collateralwithnomination.deposit_collateralandnomination.withdraw_collateralrespectively.