Fix/negative apy #1136
Merged
Fix/negative apy #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
|
@crypto-engineer @nud3l please review I see that there are a lot of commits that are related to merge interlay into my own repo, let me know if that's an issue, will clean that up :) |
danielsimao
requested changes
Apr 20, 2023
src/pages/Loans/LoansOverview/components/BorrowAssetsTable/BorrowAssetsTable.tsx
Outdated
Show resolved
Hide resolved
Chanakya888
force-pushed
the
fix/negative-apy
branch
from
4ea09f6 to
1072b37
Compare
|
@danielsimao I've added "-" to the tooltip, removed the unnecessary type which I created earlier and also cleaned up the commit log. Please review now |
|
@Chanakya888 Looks good. We just need to hold on a bit on the PR until the pipeline is fixed by @peterslany. Thank you so much for your contribution. |
danielsimao
approved these changes
Apr 24, 2023
danielsimao
requested changes
Apr 24, 2023
danielsimao
approved these changes
Apr 26, 2023
I think the PR to fix the pipeline has already been merged, so this can be merged too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a "-" symbol for the borrow APY OG issue
New behaviour
Adding a "-" makes it more clear to the user that borrow APY accumulates cost and will need to be paid back.
Reproducible steps:
Go to Lending tab -> focus on borrow APY table -> there should be a negative in front of all the borrow APY values