Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rui/sign tcs and update wallet connectaccount select #1157

Merged
merged 7 commits into from
May 9, 2023
Merged

Rui/sign tcs and update wallet connectaccount select #1157

merged 7 commits into from
May 9, 2023

Conversation

danielsimao
Copy link
Member

@danielsimao danielsimao commented Apr 26, 2023 •
edited
Loading

Interbtc UI Pull Request Template

Description

  • Added T&C new interaction and improvements
  • Revamped AccountModal into AuthModal
  • Added tests for AuthModal
  • Exported withStep hoc

https://www.loom.com/share/851c48e5c9864961abde215a83c5cf43

@danielsimao danielsimao linked an issue Apr 26, 2023 that may be closed by this pull request
Sign T&Cs and update wallet connect/account select #1143
Closed
@danielsimao danielsimao marked this pull request as draft April 26, 2023 14:46
@vercel
Copy link

vercel bot commented Apr 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 9:06am
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 9:06am
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 9:06am
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 9:06am

@danielsimao danielsimao force-pushed the rui/sign-tcs-and-update-wallet-connectaccount-select branch from af3adf9 to cf9446c Compare April 26, 2023 16:33
@github-actions
Copy link

Running Lighthouse audit...

@danielsimao danielsimao requested a review from tomjeatt April 27, 2023 11:11
@danielsimao danielsimao force-pushed the rui/sign-tcs-and-update-wallet-connectaccount-select branch from f45eb5a to eac8d3b Compare April 27, 2023 16:15
@danielsimao danielsimao marked this pull request as ready for review April 27, 2023 16:15
tomjeatt
tomjeatt approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good—one possible change, but not a blocker

src/components/AuthModal/AuthModal.tsx Outdated Show resolved Hide resolved
@danielsimao danielsimao closed this May 5, 2023
@danielsimao danielsimao reopened this May 9, 2023
@danielsimao danielsimao merged commit e8a7469 into master May 9, 2023
@danielsimao danielsimao deleted the rui/sign-tcs-and-update-wallet-connectaccount-select branch May 9, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign T&Cs and update wallet connect/account select
2 participants
@danielsimao @tomjeatt