Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Layout and MainContainer #1489

Merged
merged 1 commit into from
Jul 26, 2023
Merged

refactor: Layout and MainContainer #1489

merged 1 commit into from
Jul 26, 2023

Conversation

danielsimao
Copy link
Member

@danielsimao danielsimao commented Jul 26, 2023 •
edited
Loading

Interbtc UI Pull Request Template

Description

Improved the semantics of our layout

@danielsimao danielsimao linked an issue Jul 26, 2023 that may be closed by this pull request
Update layout components #1487
Closed
@vercel
Copy link

vercel bot commented Jul 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 8:17am
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 8:17am
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 8:17am
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 8:17am

@danielsimao danielsimao requested a review from tomjeatt July 26, 2023 08:11
@github-actions
Copy link

Running Lighthouse audit...

tomjeatt
tomjeatt approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good—can you remember to add closes [issue number] to the PR description, so that the tasks are automatically closed?

@danielsimao danielsimao merged commit ca68f9e into master Jul 26, 2023
@danielsimao danielsimao deleted the rui/update-layout-component branch July 26, 2023 09:21
@danielsimao
Copy link
Member Author

Looks good—can you remember to add closes [issue number] to the PR description, so that the tasks are automatically closed?

I created the branch from the issue so it gets cllsoed when this PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update layout components
2 participants
@danielsimao @tomjeatt