feat: contracts pallet on Kintsugi #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
force-pushed
the
kintsugi-contracts
branch
from
b6a9097
to
fcb00f7
Compare
gregdhill
reviewed
Jul 20, 2023
sander2
force-pushed
the
kintsugi-contracts
branch
from
4a2397a
to
b4435a1
Compare
sander2
force-pushed
the
kintsugi-contracts
branch
from
0e5a212
to
1124408
Compare
sander2
force-pushed
the
kintsugi-contracts
branch
from
1124408
to
01c6c60
Compare
gregdhill
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not working, due to us having an existential deposit of zero. The contracts pallet is attempting to create an account here, but due to the ED being zero, that is a no-op, so the inc_consumers afterwards fails.
We could work around this by providing the pallet with a customized
Currencythat has a non-zero ED, but I'm a bit worried this may have unforeseen consequences..Currently on top of the polkadot 0.9.42 branch, I can rebase after that is merged
Closes #983