feat: separate manual-seal #1151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
commented
Jul 31, 2023
Comment on lines
+750
to
+751
| // combine so we can still seal blocks manually | ||
| Box::new(futures::stream_select!(commands_stream, import_stream)) |
There was a problem hiding this comment.
Just noting that other projects (such as moonbeam) don't allow manual-seal as well as instant-seal.
|
Why do we want manual seal at all? |
|
It could be useful when the tester wants to include multiple transactions in a block, since instant-seal would mine when a single transaction is received this wouldn't be possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1140