wip: vault key split #616
Closed
wip: vault key split #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
reviewed
May 24, 2022
crates/replace/src/lib.rs
Outdated
Comment on lines
210
to
211
| stash_id: T::AccountId, | ||
| currency_pair: DefaultVaultCurrencyPair<T>, |
There was a problem hiding this comment.
We can probably merge this into one argument, the VaultId.
sander2
reviewed
May 24, 2022
crates/vault-registry/src/types.rs
Outdated
| @@ -814,6 +831,10 @@ impl<T: Config> UpdatableVault<T> for RichSystemVault<T> { | |||
| ) | |||
| } | |||
|
|
|||
| fn control(&self) -> T::AccountId { | |||
| Pallet::<T>::liquidation_vault_account_id() | |||
There was a problem hiding this comment.
This doesn't really make sense for the liquidation vault. Would it be possible to move this function to the RichVault impl, rather than the trait impl?
|
Closing this in favour of the operator / delegator model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #599. The migration still needs to be added, but I'm opening this to get some early feedback.